Skip to content

cp, tail: omit pipe() if input or output is pipe#12359

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cpstream-omit-pipe
Open

cp, tail: omit pipe() if input or output is pipe#12359
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cpstream-omit-pipe

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 18, 2026 •
edited
Loading

We don't need additional 1 MiB pipe for stream input. Closes #12358 .

I iwill include fallback to the fn introduced at here. So this closes #12365 .

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026 •
edited
Loading

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@oech3 oech3 marked this pull request as ready for review May 18, 2026 07:08
@oech3 oech3 force-pushed the cpstream-omit-pipe branch from 44a644f to a1102dd Compare May 18, 2026 08:45
@oech3 oech3 mentioned this pull request May 18, 2026
Open
xtqqczze
xtqqczze reviewed May 18, 2026
View reviewed changes
Comment thread src/uucore/src/lib/features/buf_copy/linux.rs
@oech3 oech3 force-pushed the cpstream-omit-pipe branch 2 times, most recently from 3cd902f to 3f8991e Compare May 18, 2026 15:32
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 18, 2026

tail has same issue.

@oech3 oech3 force-pushed the cpstream-omit-pipe branch from 3f8991e to 7e64abe Compare May 18, 2026 17:31
@oech3 oech3 changed the title cp: omit pipe() if input is pipe cp, tail: omit pipe() if input is pipe May 18, 2026
@oech3 oech3 changed the title cp, tail: omit pipe() if input is pipe cp, tail: omit pipe() if input or output is pipe May 18, 2026
xtqqczze
xtqqczze reviewed May 18, 2026
View reviewed changes
Comment thread src/uucore/src/lib/features/buf_copy/linux.rs
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 18, 2026

There is doc issue and unnecessary wrap on splice_unbounded. But I wait merging this.

@oech3 oech3 mentioned this pull request May 18, 2026
Open
@xtqqczze xtqqczze mentioned this pull request May 18, 2026
Open
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 18, 2026

The use of std::io::Result<bool>, where true represents a fallback state rather than success, is confusing. It would be clearer to refactor this first: #12365.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 19, 2026 via email •
edited
Loading

@oech3 oech3 force-pushed the cpstream-omit-pipe branch 2 times, most recently from c9fa99b to b38eef8 Compare May 19, 2026 16:40
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 19, 2026

Please remove "Closes #12365" from the PR description.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 19, 2026

No. I'll embedded the fallback itself soon. So this is not compatible with your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp, tail: unnecessary pipe call

2 participants

@oech3 @xtqqczze